Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(convert): added test for consistent coverage for update last-upd… #1299

Merged

Conversation

laurentiuNiculae
Copy link
Contributor

…ated timestamp function

What type of PR is this?
coverage

Which issue does this PR fix:
Closes #1296

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 23, 2023

Codecov Report

Merging #1299 (72e0307) into main (9171591) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #1299      +/-   ##
==========================================
+ Coverage   90.36%   90.40%   +0.03%     
==========================================
  Files          95       97       +2     
  Lines       21318    21331      +13     
==========================================
+ Hits        19265    19284      +19     
+ Misses       1538     1531       -7     
- Partials      515      516       +1     
Impacted Files Coverage Δ
pkg/extensions/search/convert/repodb.go 97.59% <100.00%> (ø)

... and 16 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@laurentiuNiculae laurentiuNiculae force-pushed the convert-repodb-coverage-fix branch 3 times, most recently from cb38ccc to 641f97d Compare March 28, 2023 14:19
@laurentiuNiculae laurentiuNiculae marked this pull request as ready for review March 28, 2023 17:07
andaaron
andaaron previously approved these changes Mar 29, 2023
…ated timestamp function

Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
@andaaron andaaron merged commit 0ae35e9 into project-zot:main Mar 29, 2023
@laurentiuNiculae laurentiuNiculae deleted the convert-repodb-coverage-fix branch May 2, 2023 10:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Coverage] Fix flaky coverage in pkg/extensions/search/convert/repodb.go
2 participants