test: stop task scheduler between test runs #1311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peusebiu
force-pushed
the
improve_sync
branch
3 times, most recently
from
d9c6f03
to
e3d169f
Compare
Codecov Report
@@ Coverage Diff @@
## main #1311 +/- ##
==========================================
+ Coverage 90.38% 90.46% +0.08%
==========================================
Files 97 97
Lines 21331 21338 +7
==========================================
+ Hits 19280 19304 +24
+ Misses 1534 1520 -14
+ Partials 517 514 -3
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
andaaron
previously approved these changes
Mar 28, 2023
peusebiu
force-pushed
the
improve_sync
branch
2 times, most recently
from
06f998c
to
9fa54cc
Compare
sync: remove sync WaitGroup, it's stopped with context sync: onDemand will always try to sync newest image when a tag is used if a digest is used then onDemand will serve local image test(sync): fix flaky coverage in sync package closes project-zot#1294 Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
andaaron
approved these changes
Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync: remove sync WaitGroup, it's stopped with context
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.