refactor: move pkg/extensions/search/common/oci_layout.go un…

[nicoldr]

…der pkg/test/

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Merging #1325 (cf3df84) into main (38997be) will increase coverage by 0.09%.
The diff coverage is 91.07%.

@@            Coverage Diff             @@
##             main    #1325      +/-   ##
==========================================
+ Coverage   90.37%   90.47%   +0.09%     
==========================================
  Files          97       97              
  Lines       21336    21142     -194     
==========================================
- Hits        19283    19128     -155     
+ Misses       1539     1504      -35     
+ Partials      514      510       -4     

Impacted Files	Coverage Δ
pkg/extensions/search/convert/oci.go	94.82% <ø> (-3.86%)	⬇️
pkg/extensions/search/resolver.go	96.40% <ø> (+1.74%)	⬆️
pkg/test/oci_layout.go	91.18% <90.19%> (ø)
pkg/extensions/sync/utils.go	90.17% <100.00%> (+1.89%)	⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[andaaron]

The ZAP scan failure is unrelated.

[nicoldr]

The ZAP scan failure is unrelated.

Thank you

[rchincha]

@nicoldr why do we need pkg/search/common/ anymore now?

[nicoldr]

@nicoldr why do we need pkg/search/common/ anymore now?

We have here the logic for tags and labels, also the functions to get all kinds of details contained in these labels and tags

[rchincha]

@nicoldr why do we need pkg/search/common/ anymore now?

We have here the logic for tags and labels, also the functions to get all kinds of details contained in these labels and tags

"common" with what? typically represents some shared code with other parts of the codebase. If this is confined to search/ alone, would just move it up to under pkg/search/ itself.

[nicoldr]

@nicoldr why do we need pkg/search/common/ anymore now?

We have here the logic for tags and labels, also the functions to get all kinds of details contained in these labels and tags

"common" with what? typically represents some shared code with other parts of the codebase. If this is confined to search/ alone, would just move it up to under pkg/search/ itself.

Hello, Ram. I tried today the scenario in which we move all the code inside common directly under search, but import problems appeared. I had a meeting with Andrei and a new issue was created, and there you can see propositions to move for all the parts that are under search/common right now. Can you take a look at the issue and see if the suggested changes seem alright to you? New issue: #1342

Since it will be quite a work to do there, that PR would be independent from this one and can be reviewed separately

[rchincha]

lgtm

Ok let this be first part of the changes