feat: remove usage of zerolog.Logger.Msgf() from zot code #1382
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicoldr
requested review from
adodon2go,
peusebiu,
shimish2,
rchincha and
andaaron
as code owners
nicoldr
force-pushed
the
modifyZerlogMsg
branch
3 times, most recently
from
a74c6db
to
aa6b642
Compare
andaaron
reviewed
Apr 24, 2023
nicoldr
force-pushed
the
modifyZerlogMsg
branch
3 times, most recently
from
9348ea5
to
49c6312
Compare
Codecov Report
@@ Coverage Diff @@
## main #1382 +/- ##
==========================================
- Coverage 90.70% 90.68% -0.02%
==========================================
Files 99 99
Lines 22268 22329 +61
==========================================
+ Hits 20198 20250 +52
- Misses 1544 1553 +9
Partials 526 526
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
nicoldr
force-pushed
the
modifyZerlogMsg
branch
from
49c6312
to
9d5fb0f
Compare
Signed-off-by: Nicol Draghici <idraghic@cisco.com>
andaaron
reviewed
Apr 26, 2023
nicoldr
force-pushed
the
modifyZerlogMsg
branch
3 times, most recently
from
196ec31
to
7d33a95
Compare
andaaron
approved these changes
Apr 27, 2023
rchincha
reviewed
Apr 28, 2023
| @@ -405,7 +405,8 @@ func (c *Controller) getSubStore(subPaths map[string]config.StorageConfig, | |||
| } else { | |||
| storeName := fmt.Sprintf("%v", storageConfig.StorageDriver["name"]) | |||
| if storeName != storage.S3StorageDriverName { | |||
| c.Log.Fatal().Err(errors.ErrBadConfig).Msgf("unsupported storage driver: %s", storageConfig.StorageDriver["name"]) | |||
| c.Log.Fatal().Err(errors.ErrBadConfig).Str("storageDriver", storeName). | |||
| Msg("unsupported storage driver") | |||
There was a problem hiding this comment.
So, now I can column-search for "unsupported storage driver".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
Closes #1366
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.