fix(authz): get username from authn.go request context #1383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #1383 +/- ##
==========================================
- Coverage 90.71% 90.70% -0.01%
==========================================
Files 99 99
Lines 22246 22253 +7
==========================================
+ Hits 20180 20185 +5
- Misses 1540 1542 +2
Partials 526 526
... and 1 file with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
peusebiu
commented
Apr 21, 2023
andaaron
reviewed
Apr 24, 2023
peusebiu
force-pushed
the
authz_fail
branch
4 times, most recently
from
5791261
to
9cfcfdc
Compare
andaaron
reviewed
Apr 25, 2023
peusebiu
force-pushed
the
authz_fail
branch
3 times, most recently
from
da778b0
to
1b2ef2b
Compare
andaaron
previously approved these changes
Apr 25, 2023
peusebiu
force-pushed
the
authz_fail
branch
2 times, most recently
from
7066a44
to
18cd246
Compare
andaaron
previously approved these changes
Apr 26, 2023
rchincha
reviewed
Apr 26, 2023
pkg/api/authz.go
Outdated
|
|
||
| readGlobPatterns := ac.getGlobPatterns(username, acCtx.Groups, Read) | ||
| dmcGlobPatterns := ac.getGlobPatterns(username, acCtx.Groups, DetectManifestCollision) | ||
| // getContext updates an AccessControlContext for a user/anonymous and returns it. |
There was a problem hiding this comment.
Leave it as getContext()
peusebiu
commented
Apr 26, 2023
pkg/api/authz.go
Outdated
| readGlobPatterns := ac.getGlobPatterns(username, acCtx.Groups, Read) | ||
| dmcGlobPatterns := ac.getGlobPatterns(username, acCtx.Groups, DetectManifestCollision) | ||
| // getContext updates an AccessControlContext for a user/anonymous and returns it. | ||
| func (ac *AccessController) updateContext(acCtx *localCtx.AccessControlContext, request *http.Request) context.Context { |
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.