-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(digests): do not mandate sha256 as the only algorithm used for hashing blobs #2075
base: main
Are you sure you want to change the base?
Conversation
c4c6abd
to
74edc3c
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2075 +/- ##
==========================================
+ Coverage 92.86% 92.88% +0.02%
==========================================
Files 167 167
Lines 22077 22128 +51
==========================================
+ Hits 20502 20554 +52
+ Misses 982 980 -2
- Partials 593 594 +1 ☔ View full report in Codecov by Sentry. |
9eed9c5
to
0aa09f8
Compare
17a45e0
to
b433e93
Compare
See also opencontainers/distribution-spec#494 |
2850123
to
bb85774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
7e0f24e
to
d80d60f
Compare
e3e9d80
to
3073f17
Compare
b0fca40
to
22f7136
Compare
a95bf1e
to
23eb7bd
Compare
…shing blobs Signed-off-by: Andrei Aaron <aaaron@luxoft.com>
|
We need the spec for specifying a non-canonical digest algorithm for the manifest in case of pushing by tag. Otherwise this PR should be good for the blobs use case. But I don't know if there's any case in which the blobs use non-canonical digest algorithms while the manifest uses the canonical (sha256) digest algorithm. |
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.