remove unnecessary calls to storage driver #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yes, we can assume some of these checks to be unnecessary. If there is an error just log that. |
andaaron
reviewed
May 30, 2024
peusebiu
force-pushed
the
fewer_catalog_calls
branch
from
fd8a701
to
9665e3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2432 +/- ##
==========================================
- Coverage 92.85% 92.83% -0.03%
==========================================
Files 169 169
Lines 22316 22302 -14
==========================================
- Hits 20721 20703 -18
- Misses 993 997 +4
Partials 602 602 ☔ View full report in Codecov by Sentry. |
peusebiu
force-pushed
the
fewer_catalog_calls
branch
2 times, most recently
from
d85f4e5
to
8cada5b
Compare
andaaron
approved these changes
Jun 4, 2024
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
peusebiu
force-pushed
the
fewer_catalog_calls
branch
from
8cada5b
to
8b20ccc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.