-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update deps to github.com/zitadel/oidc/v3 #2583
base: main
Are you sure you want to change the base?
Conversation
pkg/api/routes.go
Outdated
@@ -1873,22 +1873,22 @@ func (rh *RouteHandler) Logout(response http.ResponseWriter, request *http.Reque | |||
} | |||
|
|||
// github Oauth2 CodeExchange callback. | |||
func (rh *RouteHandler) GithubCodeExchangeCallback() rp.CodeExchangeCallback { | |||
func GithubCodeExchangeCallback[C oidc.IDClaims](c *Controller) rp.CodeExchangeCallback[C] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why was this change needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
zitadel v3 made tokens as a generic type, so this needs resolving.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pkg/api/routes.go:1876:54: cannot use generic type rp.CodeExchangeCallback[C "github.com/zitadel/oidc/v3/pkg/oidc".IDClaims] without instantiation
pkg/api/routes.go:1878:11: cannot use generic type "github.com/zitadel/oidc/v3/pkg/oidc".Tokens[C "github.com/zitadel/oidc/v3/pkg/oidc".IDClaims] without instantiation
pkg/api/routes.go:1911:54: cannot use generic type rp.CodeExchangeUserinfoCallback[C "github.com/zitadel/oidc/v3/pkg/oidc".IDClaims, U rp.SubjectGetter] without instantiation
pkg/api/routes.go:1912:62: cannot use generic type "github.com/zitadel/oidc/v3/pkg/oidc".Tokens[C "github.com/zitadel/oidc/v3/pkg/oidc".IDClaims] without instantiation
pkg/api/routes.go:1915:17: info.GetEmail undefined (type "github.com/zitadel/oidc/v3/pkg/oidc".UserInfo has no field or method GetEmail)
pkg/api/routes.go:1925:19: info.GetClaim undefined (type "github.com/zitadel/oidc/v3/pkg/oidc".UserInfo has no field or method GetClaim)
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.