Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install notation as prerequisite for test Makefile target #326

Merged
merged 1 commit into from
Dec 21, 2021

Conversation

adodon2go
Copy link
Collaborator

What type of PR is this?
bug fix

Which issue does this PR fix:

What does this PR do / Why do we need it:
When running 'make test' the tests will fail if the user does not have notation tool installed.
We need a target that will check if notation is installed and if it is not- to install it before running the tests.

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Failures:

  • zotregistry.io/zot/pkg/api_test/controller_test.go
    Line 2971:
    Expected: nil
    Actual: 'exec: "notation": executable file not found in $PATH'

524 total assertions

--- FAIL: TestImageSignatures (4.50s)

Testing done on this change:
'make test' passes regardless if you have notation tool installed or not

Automation added to e2e:
Not needed

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:
No


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Dec 15, 2021

Codecov Report

Merging #326 (1861597) into main (ac3801e) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #326   +/-   ##
=======================================
  Coverage   80.28%   80.28%           
=======================================
  Files          46       46           
  Lines        6294     6294           
=======================================
  Hits         5053     5053           
  Misses        873      873           
  Partials      368      368           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac3801e...1861597. Read the comment docs.

Makefile Outdated Show resolved Hide resolved
@adodon2go adodon2go force-pushed the fix-test-target branch 2 times, most recently from 98c3880 to 52db46d Compare December 20, 2021 18:45
Makefile Outdated Show resolved Hide resolved
Signed-off-by: Alexei Dodon <adodon@cisco.com>
@andaaron andaaron merged commit eff6ddc into project-zot:main Dec 21, 2021
@adodon2go adodon2go deleted the fix-test-target branch December 21, 2021 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants