Install notation as prerequisite for test Makefile target #326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
bug fix
Which issue does this PR fix:
What does this PR do / Why do we need it:
When running 'make test' the tests will fail if the user does not have notation tool installed.
We need a target that will check if notation is installed and if it is not- to install it before running the tests.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Failures:
Line 2971:
Expected: nil
Actual: 'exec: "notation": executable file not found in $PATH'
524 total assertions
--- FAIL: TestImageSignatures (4.50s)
Testing done on this change:
'make test' passes regardless if you have notation tool installed or not
Automation added to e2e:
Not needed
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.