ci/cd: fix github workflow to upload release binaries #333
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes issue project-zot#332 Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Codecov Report
@@ Coverage Diff @@
## main #333 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 46 46
Lines 6265 6265
=======================================
Hits 5064 5064
Misses 868 868
Partials 333 333 Continue to review full report at Codecov.
|
Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
rchincha
force-pushed
the
fix-upload-bins
branch
from
595d16d
to
2b889cf
Compare
andaaron
approved these changes
Dec 16, 2021
adodon2go
approved these changes
Dec 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #332
Signed-off-by: Ramkumar Chinchani rchincha@cisco.com
What type of PR is this?
ci/cd bug fix
Which issue does this PR fix:
issue #332
What does this PR do / Why do we need it:
ci/cd doesn't publish binaries during releases
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Do a release.
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.