Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix negative WaitGroup counter at runtime #338

Merged
merged 1 commit into from
Dec 18, 2021

Conversation

peusebiu
Copy link
Collaborator

Signed-off-by: Petu Eusebiu peusebiu@cisco.com

What type of PR is this?

bug

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
@codecov
Copy link

codecov bot commented Dec 17, 2021

Codecov Report

Merging #338 (15cb647) into main (fc4a34d) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #338   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files          46       46           
  Lines        6265     6265           
=======================================
  Hits         5064     5064           
  Misses        868      868           
  Partials      333      333           
Impacted Files Coverage Δ
pkg/extensions/sync/sync.go 88.54% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc4a34d...15cb647. Read the comment docs.

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 5f04092 into project-zot:main Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants