Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leave zot repositories in a consistent state after zot hits fd limit closes #359 #381

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

adodon2go
Copy link
Collaborator

Signed-off-by: Alexei Dodon adodon@cisco.com

What type of PR is this?
bug

Which issue does this PR fix:
#359

What does this PR do / Why do we need it:

  1. Prevents zot from crashing when FD limit reached
  2. Performs blobs/manifest cleanup to leave zot image repository in a consistent state

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Jan 23, 2022

Codecov Report

Merging #381 (df7e1e6) into main (ba41368) will increase coverage by 0.34%.
The diff coverage is 95.91%.

❗ Current head df7e1e6 differs from pull request most recent head c19f594. Consider uploading reports for the commit c19f594 to get more accurate results

@@            Coverage Diff             @@
##             main     #381      +/-   ##
==========================================
+ Coverage   84.47%   84.81%   +0.34%     
==========================================
  Files          51       51              
  Lines       10548    10567      +19     
==========================================
+ Hits         8910     8962      +52     
+ Misses       1282     1244      -38     
- Partials      356      361       +5     
Impacted Files Coverage Δ
pkg/api/routes.go 76.89% <94.28%> (+2.09%) ⬆️
pkg/api/errors.go 100.00% <100.00%> (ø)
pkg/storage/storage_fs.go 80.93% <100.00%> (+1.76%) ⬆️
pkg/extensions/sync/sync.go 85.51% <0.00%> (-1.38%) ⬇️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@andaaron andaaron added this to In progress in zot-core Jan 26, 2022
@adodon2go adodon2go changed the title bug storage: zot crashes if fd-limit reached closes #359 Leave zot repositories in a consistent state after zot hits fd limit closes #359 Feb 9, 2022
@rchincha rchincha added the bug Something isn't working label Feb 17, 2022
@rchincha rchincha added this to the v1.3.9 milestone Feb 17, 2022
@adodon2go adodon2go force-pushed the zot-crash branch 3 times, most recently from d8e0254 to a82b06c Compare March 9, 2022 11:21
@adodon2go adodon2go force-pushed the zot-crash branch 3 times, most recently from df7e1e6 to a6d2adb Compare March 28, 2022 16:51
@adodon2go adodon2go moved this from In progress to Review pending in zot-core Mar 30, 2022
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zot-core automation moved this from Review pending to Reviewer approved Mar 31, 2022
@rchincha rchincha merged commit ad519e2 into project-zot:main Mar 31, 2022
zot-core automation moved this from Reviewer approved to Done Mar 31, 2022
@adodon2go adodon2go deleted the zot-crash branch August 23, 2023 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
zot-core
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants