Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: support reloading sync config when the config file changes #406

Merged
merged 1 commit into from
Mar 18, 2022

Conversation

peusebiu
Copy link
Collaborator

Signed-off-by: Petu Eusebiu peusebiu@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@peusebiu peusebiu force-pushed the sync_reload branch 2 times, most recently from 7ae830d to 477ebab Compare February 11, 2022 12:52
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #406 (32ea614) into main (7e8cc3c) will increase coverage by 0.14%.
The diff coverage is 89.31%.

@@            Coverage Diff             @@
##             main     #406      +/-   ##
==========================================
+ Coverage   83.80%   83.94%   +0.14%     
==========================================
  Files          49       50       +1     
  Lines       10210    10290      +80     
==========================================
+ Hits         8556     8638      +82     
+ Misses       1294     1293       -1     
+ Partials      360      359       -1     
Impacted Files Coverage Δ
pkg/extensions/extensions.go 80.82% <50.00%> (ø)
pkg/cli/config_reloader.go 78.04% <78.04%> (ø)
pkg/cli/root.go 92.95% <89.74%> (+4.18%) ⬆️
pkg/api/controller.go 91.82% <100.00%> (+0.80%) ⬆️
pkg/extensions/sync/sync.go 90.96% <100.00%> (+0.20%) ⬆️
pkg/extensions/sync/utils.go 79.64% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peusebiu peusebiu force-pushed the sync_reload branch 8 times, most recently from 2bc03b7 to cdcc6fa Compare February 16, 2022 11:56
@peusebiu peusebiu added this to In progress in zot-core via automation Feb 16, 2022
@peusebiu peusebiu moved this from In progress to Review pending in zot-core Feb 16, 2022
@rchincha rchincha added this to the v1.3.9 milestone Feb 16, 2022
@rchincha rchincha modified the milestones: v1.3.9, v1.4.0 Mar 3, 2022
@peusebiu peusebiu force-pushed the sync_reload branch 8 times, most recently from db438f6 to 6bb893d Compare March 16, 2022 16:51
pkg/api/controller.go Outdated Show resolved Hide resolved
pkg/api/controller.go Outdated Show resolved Hide resolved
@peusebiu peusebiu force-pushed the sync_reload branch 2 times, most recently from a567740 to 4744d31 Compare March 18, 2022 15:11
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zot-core automation moved this from Review pending to Reviewer approved Mar 18, 2022
@rchincha rchincha merged commit 6d04ab3 into project-zot:main Mar 18, 2022
zot-core automation moved this from Reviewer approved to Done Mar 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
zot-core
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants