build: add -buildmode=pie to builds #412
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #412 +/- ##
=======================================
Coverage 84.41% 84.41%
=======================================
Files 51 51
Lines 10548 10548
=======================================
Hits 8904 8904
Misses 1287 1287
Partials 357 357 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
rchincha
force-pushed
the
fix-build
branch
2 times, most recently
from
ab384c8
to
aa2afd5
Compare
peusebiu
previously approved these changes
Feb 23, 2022
rchincha
force-pushed
the
fix-build
branch
2 times, most recently
from
a187e94
to
df7cf6f
Compare
This makes zot a dynamic binary, so the container base image has to be changed accordingly Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
peusebiu
approved these changes
Mar 24, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ramkumar Chinchani rchincha@cisco.com
What type of PR is this?
build
Which issue does this PR fix:
What does this PR do / Why do we need it:
Adds -buildmode=pie to build PIE binaries.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.