Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added clustering github workflow #416

Merged
merged 1 commit into from
Mar 9, 2022

Conversation

peusebiu
Copy link
Collaborator

Signed-off-by: Petu Eusebiu peusebiu@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Feb 18, 2022

Codecov Report

Merging #416 (85465f0) into main (b8010e1) will decrease coverage by 0.04%.
The diff coverage is n/a.

❗ Current head 85465f0 differs from pull request most recent head 6e7bad0. Consider uploading reports for the commit 6e7bad0 to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #416      +/-   ##
==========================================
- Coverage   83.77%   83.73%   -0.05%     
==========================================
  Files          49       49              
  Lines       10194    10168      -26     
==========================================
- Hits         8540     8514      -26     
  Misses       1294     1294              
  Partials      360      360              
Impacted Files Coverage Δ
pkg/api/authn.go 77.50% <0.00%> (-1.77%) ⬇️
pkg/api/controller.go 90.66% <0.00%> (-0.29%) ⬇️
pkg/api/routes.go 74.22% <0.00%> (-0.06%) ⬇️
pkg/api/config/config.go 79.31% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b8010e1...6e7bad0. Read the comment docs.

@peusebiu peusebiu force-pushed the cluster_workflow branch 4 times, most recently from 34f7b4f to da71e31 Compare February 18, 2022 15:17
@peusebiu
Copy link
Collaborator Author

need to change localstack with minio, as localstack seems to be very slow.

@peusebiu peusebiu force-pushed the cluster_workflow branch 11 times, most recently from ab81f38 to 77a89fc Compare February 22, 2022 14:26
@peusebiu peusebiu added this to In progress in zot-core via automation Feb 22, 2022
test/cluster/haproxy.cfg Outdated Show resolved Hide resolved
@peusebiu peusebiu force-pushed the cluster_workflow branch 6 times, most recently from 3c20c42 to bd0dc6f Compare February 28, 2022 13:44
@rchincha rchincha added this to the v1.4.0 milestone Mar 2, 2022
@peusebiu peusebiu force-pushed the cluster_workflow branch 3 times, most recently from 40f91c1 to a50781f Compare March 2, 2022 18:39
@peusebiu peusebiu removed the bug Something isn't working label Mar 2, 2022
@rchincha
Copy link
Contributor

rchincha commented Mar 7, 2022

Also,

Complete requests:    0
Failed requests:      100

@peusebiu peusebiu force-pushed the cluster_workflow branch 7 times, most recently from 85465f0 to 4fd53f2 Compare March 7, 2022 14:13
@peusebiu
Copy link
Collaborator Author

peusebiu commented Mar 7, 2022

Also,

Complete requests:    0
Failed requests:      100

that happened because of s3 bug, now that it's fixed it works without any issue.

@rchincha
Copy link
Contributor

rchincha commented Mar 8, 2022

@peusebiu, disable logs ("output": "/dev/null") so that the output is clean and readable.

@peusebiu peusebiu force-pushed the cluster_workflow branch 4 times, most recently from 8a63d6c to 63ed2bc Compare March 9, 2022 16:31
@andaaron andaaron moved this from In progress to Review pending in zot-core Mar 9, 2022
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zot-core automation moved this from Review pending to Reviewer approved Mar 9, 2022
@rchincha rchincha merged commit fa27e22 into project-zot:main Mar 9, 2022
zot-core automation moved this from Reviewer approved to Done Mar 9, 2022
vrajashkr pushed a commit to vrajashkr/zot that referenced this pull request Apr 11, 2024
Signed-off-by: Laurentiu Niculae <niculae.laurentiu1@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
zot-core
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants