routes: changes required to do browser authentication #429
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimish2
force-pushed
the
ui-browser-auth
branch
from
f63c259
to
22484ff
Compare
Codecov Report
@@ Coverage Diff @@
## main #429 +/- ##
==========================================
+ Coverage 83.73% 83.77% +0.04%
==========================================
Files 49 49
Lines 10168 10194 +26
==========================================
+ Hits 8514 8540 +26
Misses 1294 1294
Partials 360 360
Continue to review full report at Codecov.
|
shimish2
force-pushed
the
ui-browser-auth
branch
2 times, most recently
from
cb4efa0
to
078bc2d
Compare
shimish2
force-pushed
the
ui-browser-auth
branch
from
078bc2d
to
85d194b
Compare
rchincha
reviewed
Mar 3, 2022
shimish2
force-pushed
the
ui-browser-auth
branch
from
85d194b
to
e8cab22
Compare
shimish2
force-pushed
the
ui-browser-auth
branch
from
e8cab22
to
f47115c
Compare
rchincha
reviewed
Mar 7, 2022
rchincha
reviewed
Mar 7, 2022
rchincha
reviewed
Mar 7, 2022
rchincha
reviewed
Mar 7, 2022
rchincha
reviewed
Mar 7, 2022
shimish2
force-pushed
the
ui-browser-auth
branch
3 times, most recently
from
4fc26b3
to
59b6176
Compare
shimish2
force-pushed
the
ui-browser-auth
branch
from
59b6176
to
6506208
Compare
whenever we make a request that contains header apart from CORS allowed header, browser sends a preflight request and in response accept *Access-Control-Allow-Headers*. preflight request is in form of OPTIONS method, added new http handler func to set headers and returns HTTP status ok in case of OPTIONS method. in case of authorization, request contains authorization header added authorization header in Access-Control-Allow-Headers list added AllowOrigin field in HTTPConfig this field value is set to Access-Control-Allow-Origin header and will give zot adminstrator to limit incoming request. Signed-off-by: Shivam Mishra <shimish2@cisco.com>
shimish2
force-pushed
the
ui-browser-auth
branch
from
6506208
to
9f19eac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
whenever we make a request that contains header apart from CORS allowed header, browser sends a preflight request
and in response accept Access-Control-Allow-Headers.
preflight request is in form of OPTIONS method, added new http handler func to set headers
and returns HTTP status ok in case of OPTIONS method.
in case of authorization, request contains authorization header
added authorization header in Access-Control-Allow-Headers list
added AllowOrigin field in HTTPConfig this field value is set to Access-Control-Allow-Origin header and will give zot adminstrator to limit incoming request.
Signed-off-by: Shivam Mishra shimish2@cisco.com
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.