s3: bugfix, use sync.Map instead of map for storing multi part upload… #436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #436 +/- ##
==========================================
+ Coverage 83.71% 83.74% +0.02%
==========================================
Files 49 49
Lines 10158 10174 +16
==========================================
+ Hits 8504 8520 +16
Misses 1294 1294
Partials 360 360
Continue to review full report at Codecov.
|
rchincha
reviewed
Mar 2, 2022
pkg/storage/s3/storage.go
Outdated
| @@ -35,6 +35,24 @@ const ( | |||
| RWLOCK = "RWLock" | |||
| ) | |||
|
|
|||
| type multiPartUploads struct { | |||
There was a problem hiding this comment.
Did you need this struct at all? Couldn't you have just used a sync.Map directly? It is nice to have the apis, but still.
rchincha
reviewed
Mar 2, 2022
pkg/storage/s3/storage.go
Outdated
| @@ -45,8 +63,8 @@ type ObjectStorage struct { | |||
| // We must keep track of multi part uploads to s3, because the lib | |||
| // which we are using doesn't cancel multiparts uploads | |||
| // see: https://github.com/distribution/distribution/blob/main/registry/storage/driver/s3-aws/s3.go#L545 | |||
| isMultiPartUpload map[string]bool | |||
| metrics monitoring.MetricServer | |||
| multiPartUploads multiPartUploads | |||
There was a problem hiding this comment.
This could just be a sync.Map
…s references add storage lock in GetIndexContent Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…s references
add storage lock in GetIndexContent
Signed-off-by: Petu Eusebiu peusebiu@cisco.com
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.