Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

conformance: fix cross-mount behavior when 'from' is missing #443

Merged
merged 1 commit into from
Mar 5, 2022

Conversation

rchincha
Copy link
Contributor

@rchincha rchincha commented Mar 4, 2022

fixes issue #442

Signed-off-by: Ramkumar Chinchani rchincha@cisco.com

What type of PR is this?

bug

Which issue does this PR fix:

issue #442

What does this PR do / Why do we need it:

'from' query param is not support, so conform per spec.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@rchincha rchincha requested a review from shimish2 March 4, 2022 23:23
@rchincha
Copy link
Contributor Author

rchincha commented Mar 4, 2022

Ran 60 of 65 Specs in 0.147 seconds
SUCCESS! -- 60 Passed | 0 Failed | 0 Pending | 5 Skipped
You're using deprecated Ginkgo functionality:
=============================================
Ginkgo 2.0 is under active development and will introduce (a small number of) breaking changes.
To learn more, view the migration guide at https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md
To comment, chime in at https://github.com/onsi/ginkgo/issues/711

  You are using a custom reporter.  Support for custom reporters will likely be removed in V2.  Most users were using them to generate junit or teamcity reports and this functionality will be merged into the core reporter.  In addition, Ginkgo 2.0 will support emitting a JSON-formatted report that users can then manipulate to generate custom reports.

  If this change will be impactful to you please leave a comment on https://github.com/onsi/ginkgo/issues/711
  Learn more at: https://github.com/onsi/ginkgo/blob/v2/docs/MIGRATING_TO_V2.md#removed-custom-reporters

To silence deprecations that can be silenced set the following environment variable:
  ACK_GINKGO_DEPRECATIONS=1.16.4

PASS

@rchincha rchincha force-pushed the issue-442 branch 2 times, most recently from 1b6ca37 to 4bfbd77 Compare March 4, 2022 23:53
fixes issue project-zot#442

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
@codecov
Copy link

codecov bot commented Mar 5, 2022

Codecov Report

Merging #443 (60d2d15) into main (95e4b20) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #443      +/-   ##
==========================================
- Coverage   83.74%   83.73%   -0.01%     
==========================================
  Files          49       49              
  Lines       10174    10168       -6     
==========================================
- Hits         8520     8514       -6     
  Misses       1294     1294              
  Partials      360      360              
Impacted Files Coverage Δ
pkg/api/routes.go 74.22% <ø> (-0.16%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 95e4b20...60d2d15. Read the comment docs.

Copy link
Collaborator

@shimish2 shimish2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha added bug Something isn't working conformance dist-spec conformance labels Mar 5, 2022
@rchincha rchincha added this to In progress in zot-core via automation Mar 5, 2022
@rchincha rchincha added this to the v1.4.0 milestone Mar 5, 2022
@rchincha rchincha merged commit 4be2652 into project-zot:main Mar 5, 2022
zot-core automation moved this from In progress to Done Mar 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working conformance dist-spec conformance
Projects
zot-core
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants