Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distribution-spec version named simply Version in zot logs #448

Merged
merged 1 commit into from
Mar 14, 2022

Conversation

laurentiuNiculae
Copy link
Contributor

Signed-off-by: Laurentiu Niculae niculae.laurentiu1@gmail.com
What type of PR is this?

Which issue does this PR fix:
Issue #441
What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@laurentiuNiculae laurentiuNiculae changed the title renamed config variable Distribution-spec version named simply Version in zot logs Mar 7, 2022
@laurentiuNiculae laurentiuNiculae force-pushed the clarifyDistribVersion branch 4 times, most recently from e799b48 to 80ebf36 Compare March 7, 2022 18:00
@codecov
Copy link

codecov bot commented Mar 7, 2022

Codecov Report

Merging #448 (c931305) into main (fa27e22) will increase coverage by 0.02%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   83.77%   83.80%   +0.02%     
==========================================
  Files          49       49              
  Lines       10194    10210      +16     
==========================================
+ Hits         8540     8556      +16     
  Misses       1294     1294              
  Partials      360      360              
Impacted Files Coverage Δ
pkg/api/config/config.go 79.31% <100.00%> (ø)
pkg/api/controller.go 91.02% <100.00%> (+0.07%) ⬆️
pkg/cli/root.go 88.76% <100.00%> (+0.60%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@laurentiuNiculae laurentiuNiculae marked this pull request as ready for review March 7, 2022 18:48
pkg/api/config/config.go Outdated Show resolved Hide resolved
andaaron
andaaron previously approved these changes Mar 8, 2022
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will need a rebase.

@laurentiuNiculae laurentiuNiculae force-pushed the clarifyDistribVersion branch 15 times, most recently from 57d393b to 86fad8d Compare March 10, 2022 17:48
pkg/cli/root.go Outdated Show resolved Hide resolved
@laurentiuNiculae laurentiuNiculae force-pushed the clarifyDistribVersion branch 5 times, most recently from 2a01106 to eab26d4 Compare March 11, 2022 14:55
pkg/cli/root_test.go Outdated Show resolved Hide resolved
Warning if config has wrong dist-spec version

Signed-off-by: laurentiuNiculae <themelopeus@gmail.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 63d94d4 into project-zot:main Mar 14, 2022
@laurentiuNiculae laurentiuNiculae deleted the clarifyDistribVersion branch March 30, 2022 14:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants