new config option for sync-destination

[laurentiuNiculae]

Signed-off-by: laurentiuNiculae themelopeus@gmail.com

What type of PR is this?

Which issue does this PR fix:
Issue #433

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

[codecov]

Codecov Report

Merging #454 (da1e2af) into main (6d04ab3) will increase coverage by 0.16%.
The diff coverage is 97.53%.

@@            Coverage Diff             @@
##             main     #454      +/-   ##
==========================================
+ Coverage   83.94%   84.10%   +0.16%     
==========================================
  Files          50       50              
  Lines       10290    10375      +85     
==========================================
+ Hits         8638     8726      +88     
+ Misses       1293     1290       -3     
  Partials      359      359              

Impacted Files	Coverage Δ
pkg/extensions/sync/utils.go	82.91% <96.39%> (+3.27%)	⬆️
pkg/extensions/sync/on_demand.go	88.20% <100.00%> (+0.34%)	⬆️
pkg/extensions/sync/sync.go	91.23% <100.00%> (+0.27%)	⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

[peusebiu]

given a sync content config:

Content{
    Prefix: "zot-fold/**",
    Destination: "/", 
    StripPrefix: true
}

let's say that this prefix will match an upstream image named: zot-fold/zot-fold2/alpine
with the current implementation we will store it locally as: zot-fold2/alpine

Is this ok, or StripPrefix should also strip zot-fold2? and the result should be alpine? @andaaron @rchincha

Otherwise LGTM

[rchincha]

lgtm

[rchincha]

given a sync content config:

Content{
    Prefix: "zot-fold/**",
    Destination: "/", 
    StripPrefix: true
}

let's say that this prefix will match an upstream image named: zot-fold/zot-fold2/alpine with the current implementation we will store it locally as: zot-fold2/alpine

Is this ok, or StripPrefix should also strip zot-fold2? and the result should be alpine? @andaaron @rchincha

Otherwise LGTM

This is ok

[rchincha]

Merging is blocked
The base branch requires all commits to be signed.

[rchincha]

lgtm