sync: Add a new flag to enforce syncing only signed images, closes #455 #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #456 +/- ##
==========================================
+ Coverage 84.10% 84.41% +0.30%
==========================================
Files 50 51 +1
Lines 10375 10548 +173
==========================================
+ Hits 8726 8904 +178
+ Misses 1290 1287 -3
+ Partials 359 357 -2
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
peusebiu
force-pushed
the
sync_signature_flag
branch
2 times, most recently
from
e88e902
to
e211598
Compare
peusebiu
force-pushed
the
sync_signature_flag
branch
3 times, most recently
from
0be1a20
to
5178320
Compare
rchincha
reviewed
Mar 16, 2022
peusebiu
force-pushed
the
sync_signature_flag
branch
3 times, most recently
from
32b5d67
to
969b814
Compare
rchincha
reviewed
Mar 18, 2022
rchincha
reviewed
Mar 18, 2022
peusebiu
force-pushed
the
sync_signature_flag
branch
5 times, most recently
from
969a1fc
to
8b342b3
Compare
rchincha
force-pushed
the
sync_signature_flag
branch
from
8b342b3
to
7d06794
Compare
…oject-zot#455 sync: When checking if a image is already synced also check for changes in upstream signatures. Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
peusebiu
force-pushed
the
sync_signature_flag
branch
from
7d06794
to
a949f4a
Compare
|
Too many things happening in this PR?
Let's split it like above in 3 separate commits in this PR |
Ok, I will split it into 3 commits |
peusebiu
force-pushed
the
sync_signature_flag
branch
from
a949f4a
to
513c431
Compare
…imports Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
peusebiu
force-pushed
the
sync_signature_flag
branch
from
513c431
to
a27c42c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
sync: When checking if a image is already synced also check for changes in upstream signatures.
Signed-off-by: Petu Eusebiu peusebiu@cisco.com
What type of PR is this?
Which issue does this PR fix:
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Does this change require updates to the CNI daemonset config files to work?:
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.