-
Notifications
You must be signed in to change notification settings - Fork 88
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Separate make targets that require elevated privileges #461
Conversation
6058548
to
6285ec8
Compare
7a2f4b5
to
fd9a32a
Compare
Codecov Report
@@ Coverage Diff @@
## main #461 +/- ##
==========================================
- Coverage 85.00% 84.41% -0.60%
==========================================
Files 52 51 -1
Lines 10623 10548 -75
==========================================
- Hits 9030 8904 -126
- Misses 1235 1287 +52
+ Partials 358 357 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
278bdc0
to
43bcbdb
Compare
278e054
to
badd1bd
Compare
Reworked privileged cert test so it runs in Go by moving make logic to Go logic Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
What type of PR is this?
cleanup
Which issue does this PR fix:
#459
What does this PR do / Why do we need it:
This PR separates the tests that need some sort of privileged execution from the ones that don't by use of new make targets.
This allows running without needing privileges or when they are not available.
Additionally, this PR will now make tests run on every platform (make test was only run on linux && amd64).
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.