Refactor the push/pull tests to use the bats test framework #467
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andaaron
changed the title
Codecov Report
@@ Coverage Diff @@
## main #467 +/- ##
=======================================
Coverage 84.10% 84.10%
=======================================
Files 50 50
Lines 10375 10375
=======================================
Hits 8726 8726
Misses 1290 1290
Partials 359 359 📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
andaaron
force-pushed
the
bats2
branch
2 times, most recently
from
6aa1158
to
126c38d
Compare
peusebiu
previously approved these changes
Mar 18, 2022
|
can we make this a proper patch by merging both PRs. Also pls don't add a new github workflow. |
Hi Ram, not sure I understand. This PR replaces my other PR #444, and I don't add a new workflow. |
rchincha
reviewed
Mar 22, 2022
rchincha
reviewed
Mar 22, 2022
andaaron
force-pushed
the
bats2
branch
2 times, most recently
from
3a6dcd2
to
6adaaf0
Compare
This is a follow up to project-zot#444. Signed-off-by: Andrei Aaron <andaaron@cisco.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow up to #444.
Signed-off-by: Andrei Aaron andaaron@cisco.com
What type of PR is this?
cleanup
build
What does this PR do / Why do we need it:
See #444, this PR migrates the tests in the makefile to the bats test framework.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.