Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modified shared storage haproxy config to stick only writes, not reads #471

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

peusebiu
Copy link
Collaborator

Modified shared storage haproxy config to stick only writes, not reads

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Mar 18, 2022

Codecov Report

Merging #471 (875e6b6) into main (03dd558) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #471   +/-   ##
=======================================
  Coverage   84.47%   84.47%           
=======================================
  Files          51       51           
  Lines       10548    10548           
=======================================
  Hits         8910     8910           
  Misses       1282     1282           
  Partials      356      356           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@peusebiu peusebiu force-pushed the clustering branch 2 times, most recently from 85d840b to 1835d84 Compare March 18, 2022 16:29
@peusebiu peusebiu changed the title Add a new clustering haproxy config - one zot for writes, two for reads Modified shared storage haproxy config to stick only writes, not reads Mar 22, 2022
@peusebiu peusebiu added this to In progress in zot-core via automation Mar 23, 2022
@andaaron andaaron moved this from In progress to Review pending in zot-core Mar 23, 2022
rchincha
rchincha previously approved these changes Mar 28, 2022
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zot-core automation moved this from Review pending to Reviewer approved Mar 28, 2022
zot-core automation moved this from Reviewer approved to Review pending Mar 30, 2022
Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

zot-core automation moved this from Review pending to Reviewer approved Mar 31, 2022
@rchincha rchincha merged commit ba41368 into project-zot:main Mar 31, 2022
zot-core automation moved this from Reviewer approved to Done Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
zot-core
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants