Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gc: add a unit test #478

Merged
merged 1 commit into from
Mar 24, 2022
Merged

gc: add a unit test #478

merged 1 commit into from
Mar 24, 2022

Conversation

rchincha
Copy link
Contributor

Signed-off-by: Ramkumar Chinchani rchincha@cisco.com

What type of PR is this?

unit test

Which issue does this PR fix:

What does this PR do / Why do we need it:

additional validation/coverage

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Ramkumar Chinchani <rchincha@cisco.com>
Copy link
Collaborator

@peusebiu peusebiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov
Copy link

codecov bot commented Mar 24, 2022

Codecov Report

Merging #478 (bb2d905) into main (be910cf) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #478   +/-   ##
=======================================
  Coverage   84.41%   84.41%           
=======================================
  Files          51       51           
  Lines       10548    10548           
=======================================
  Hits         8904     8904           
  Misses       1287     1287           
  Partials      357      357           
Impacted Files Coverage Δ
pkg/storage/storage_fs.go 79.16% <100.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rchincha rchincha merged commit b2a4388 into project-zot:main Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants