Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync: fix inconsistent test #489

Merged
merged 1 commit into from
Mar 31, 2022

Conversation

peusebiu
Copy link
Collaborator

Signed-off-by: Petu Eusebiu peusebiu@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #489 (0691612) into main (554e99a) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #489      +/-   ##
==========================================
- Coverage   84.52%   84.47%   -0.06%     
==========================================
  Files          51       51              
  Lines       10548    10548              
==========================================
- Hits         8916     8910       -6     
- Misses       1277     1282       +5     
- Partials      355      356       +1     
Impacted Files Coverage Δ
pkg/api/routes.go 74.79% <0.00%> (-0.62%) ⬇️
pkg/extensions/sync/sync.go 86.89% <0.00%> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 03dd558 into project-zot:main Mar 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants