Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Build images with annotations #872

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

nicoldr
Copy link
Contributor

@nicoldr nicoldr commented Oct 11, 2022

Signed-off-by: Nicol Draghici idraghic@cisco.com

What type of PR is this?

Which issue does this PR fix:
Solves #850

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Merging #872 (2449459) into main (7d08985) will decrease coverage by 0.11%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #872      +/-   ##
==========================================
- Coverage   89.00%   88.88%   -0.12%     
==========================================
  Files          72       72              
  Lines       13829    13829              
==========================================
- Hits        12308    12292      -16     
- Misses       1186     1199      +13     
- Partials      335      338       +3     
Impacted Files Coverage Δ
pkg/api/session.go 96.99% <0.00%> (-3.01%) ⬇️
pkg/storage/local/local.go 82.94% <0.00%> (-0.68%) ⬇️
pkg/scheduler/scheduler.go 91.53% <0.00%> (-0.53%) ⬇️
pkg/api/routes.go 96.95% <0.00%> (-0.28%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@nicoldr nicoldr force-pushed the annotBatsTests branch 2 times, most recently from c0fee1b to fe91105 Compare October 14, 2022 14:02
@nicoldr nicoldr marked this pull request as ready for review October 14, 2022 14:15
@nicoldr nicoldr force-pushed the annotBatsTests branch 6 times, most recently from 5a0a025 to 43a9e44 Compare October 18, 2022 12:08
Signed-off-by: Nicol Draghici <idraghic@cisco.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit d93c68a into project-zot:main Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants