Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(workflow): gql introspection - run only at release, resulting json in downloadable files #873

Merged
merged 1 commit into from
Oct 17, 2022

Conversation

chofnar
Copy link
Contributor

@chofnar chofnar commented Oct 14, 2022

What type of PR is this?
fix

What does this PR do / Why do we need it:
The workflow that checks for changed GQL schema sometimes fails. This PR makes the workflow only run at release and pushes the resulting file to the downloadable files on the release (near the binaries)

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 14, 2022

Codecov Report

Merging #873 (2b39b53) into main (1495459) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #873   +/-   ##
=======================================
  Coverage   89.00%   89.00%           
=======================================
  Files          72       72           
  Lines       13829    13829           
=======================================
  Hits        12308    12308           
  Misses       1186     1186           
  Partials      335      335           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@chofnar chofnar force-pushed the fixIntrospectionJSON branch 2 times, most recently from 88a9cb3 to 372748f Compare October 14, 2022 14:46
@chofnar chofnar marked this pull request as ready for review October 14, 2022 14:48
@chofnar chofnar self-assigned this Oct 14, 2022
@chofnar chofnar added the ci/cd label Oct 14, 2022
@chofnar chofnar marked this pull request as draft October 14, 2022 15:07
Signed-off-by: Catalin Hofnar <catalin.hofnar@gmail.com>
@chofnar chofnar changed the title fix(workflow): gql introspection - add fetch depth, removed running at release fix(workflow): gql introspection - run only at release, resulting json in downloadable files Oct 17, 2022
@chofnar chofnar marked this pull request as ready for review October 17, 2022 11:18
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 794a4aa into project-zot:main Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants