Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3): remove tracking multipart uploads #883

Merged
merged 1 commit into from
Oct 20, 2022

Conversation

peusebiu
Copy link
Collaborator

@peusebiu peusebiu commented Oct 17, 2022

Remove sticky sessions from clustering

Signed-off-by: Petu Eusebiu peusebiu@cisco.com

What type of PR is this?
cleanup

What does this PR do / Why do we need it:
Removes the need of sticky sessions in zot cluster load balancer (haproxy)

If an issue # is not available please add repro steps and logs showing the issue:

Will this break upgrades or downgrades?
no

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 18, 2022

Codecov Report

Merging #883 (ecf2b3b) into main (76714d5) will increase coverage by 0.01%.
The diff coverage is 97.67%.

@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
+ Coverage   89.00%   89.02%   +0.01%     
==========================================
  Files          72       72              
  Lines       13844    13786      -58     
==========================================
- Hits        12322    12273      -49     
+ Misses       1187     1181       -6     
+ Partials      335      332       -3     
Impacted Files Coverage Δ
pkg/storage/s3/s3.go 81.33% <97.67%> (-0.18%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@peusebiu peusebiu force-pushed the clustering_rm_sticky_sessions branch 3 times, most recently from 2f3ff51 to 5b57f78 Compare October 19, 2022 11:01
andaaron
andaaron previously approved these changes Oct 19, 2022
Copy link
Contributor

@andaaron andaaron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

pkg/storage/s3/s3.go Outdated Show resolved Hide resolved
Remove sticky sessions from clustering

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
@peusebiu peusebiu force-pushed the clustering_rm_sticky_sessions branch from 6a69b04 to ecf2b3b Compare October 20, 2022 12:36
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rchincha rchincha merged commit 92d97d4 into project-zot:main Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants