fix: replace time.sleep() with checking logs #899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aokirisaki
requested review from
rchincha,
andaaron and
peusebiu
as code owners
aokirisaki
force-pushed
the
cli-sleep
branch
2 times, most recently
from
a8d7172
to
081943f
Compare
Codecov Report
@@ Coverage Diff @@
## main #899 +/- ##
==========================================
- Coverage 89.03% 88.98% -0.06%
==========================================
Files 72 72
Lines 13798 13814 +16
==========================================
+ Hits 12285 12292 +7
- Misses 1181 1189 +8
- Partials 332 333 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
aokirisaki
force-pushed
the
cli-sleep
branch
4 times, most recently
from
3762438
to
9eed1cc
Compare
Signed-off-by: Lisca Ana-Roberta <ana.kagome@yahoo.com>
andaaron
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lisca Ana-Roberta ana.kagome@yahoo.com
What type of PR is this?
Which issue does this PR fix:
#877
What does this PR do / Why do we need it:
If an issue # is not available please add repro steps and logs showing the issue:
Testing done on this change:
Automation added to e2e:
Will this break upgrades or downgrades?
Does this PR introduce any user-facing change?:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.