Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sync): fixed broken logic to get tags for repo #900

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

peusebiu
Copy link
Collaborator

Signed-off-by: Petu Eusebiu peusebiu@cisco.com

What type of PR is this?

Which issue does this PR fix:

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades?

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 21, 2022

Codecov Report

Merging #900 (b13fc87) into main (00e65bd) will increase coverage by 0.02%.
The diff coverage is 88.71%.

@@            Coverage Diff             @@
##             main     #900      +/-   ##
==========================================
+ Coverage   89.07%   89.10%   +0.02%     
==========================================
  Files          72       72              
  Lines       13807    13758      -49     
==========================================
- Hits        12299    12259      -40     
+ Misses       1177     1169       -8     
+ Partials      331      330       -1     
Impacted Files Coverage Δ
pkg/extensions/sync/sync.go 86.00% <84.76%> (-0.06%) ⬇️
pkg/extensions/sync/signatures.go 84.56% <89.15%> (+2.99%) ⬆️
pkg/extensions/sync/utils.go 93.47% <92.68%> (-0.09%) ⬇️
pkg/extensions/sync/on_demand.go 92.01% <96.42%> (-0.15%) ⬇️
pkg/storage/local/local.go 82.94% <0.00%> (-0.68%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Petu Eusebiu <peusebiu@cisco.com>
Copy link
Contributor

@rchincha rchincha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants