Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Header is rendered when user starts scrolling up #230

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

ameliamariabreda
Copy link
Contributor

What type of PR is this?
feature

Which issue does this PR fix:
Closes #223

What does this PR do / Why do we need it:

If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:

Testing done on this change:

Automation added to e2e:

Will this break upgrades or downgrades. Has updating a running cluster been tested?:

Does this change require updates to the CNI daemonset config files to work?:

Does this PR introduce any user-facing change?:


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #230 (16b2b95) into main (146f764) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #230   +/-   ##
=======================================
  Coverage   89.09%   89.09%           
=======================================
  Files          42       42           
  Lines         954      954           
  Branches      224      225    +1     
=======================================
  Hits          850      850           
  Misses         92       92           
  Partials       12       12           
Impacted Files Coverage Δ
src/components/Header.jsx 61.11% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Signed-off-by: Amelia-Maria Breda <ambreda@cisco.com>
Copy link
Collaborator

@raulkele raulkele left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes are good, but we will need to see if there is a better way to implement this in the future. Not a fan of listening for the scroll event. Approved for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZUI: header should be shown when user starts scrolling up (or should always be visible?)
2 participants