Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSP Interpreter lle graphics issue(s) in SD Hiryuu No Ken Densetsu #2

Closed
LegendOfDragoon opened this issue Jan 22, 2015 · 6 comments
Closed

Comments

@LegendOfDragoon
Copy link
Contributor

Here's a screenshot of the intro with RSP interpreter, using HatCat's fork of Angrylion's plugin for graphics.
sd hiryuu intro

Here's what it looks like in a match, also using zilmar's RSP interpreter.
sd hiryuu match

@cxd4
Copy link
Contributor

cxd4 commented Jan 22, 2015

I have also filed a RSP pj64 interpreter bug here:
#3

I will look at this issue and mine in the next few days to see if they might be coinciding, thanks.

Also feel free to edit your message to use GitHub's native image uploading feature so that the 320x237 pictures show directly in the post--do you mean that the second one "what it looks like in a match" is with PJ64's RSP, while the first one is with mine?

@LegendOfDragoon
Copy link
Contributor Author

Both previous screenshots were taken with zilmar's RSP interpreter. I had trouble with save states, so i didn't post a comparison picture. it turns out, zilmar's RSP was also responsible for the save state problem. I'll go ahead and edit 1st post to use native image uploading feature.
Here's a decent comparison picture. I didn't take the pictures at the exact same in-game time frame.
This is with zilmar's RSP
sd hiryuu bad

This is with HatCat's RSP
sd hiryuu good

@cxd4
Copy link
Contributor

cxd4 commented Jan 22, 2015

Okay.
Now try with this commit:
https://github.com/cxd4/project64/commit/5b346077ef536a42f79ffb1b914f9dcf62f1bd6f

Your issue here looks pretty similar.
Tell me if my commit to RSP 1.7.0.9 has fixed it.

@LegendOfDragoon
Copy link
Contributor Author

Ya that fixed the gfx issues. Nice job!

@cxd4
Copy link
Contributor

cxd4 commented Jan 22, 2015

The issue is fixed now in the master branch:
2dd4e99

With this commit project64 upstream should have the issue fixed in the RSP interpreter now.

You can close this issue / mark as solved now if you like.
Unless the game still has same gfx bugs in recompiler...mine does, so I am leaving mine open.

@LegendOfDragoon
Copy link
Contributor Author

The main issue is fixed. There's one other problem (probably related to your as well). I guess I will close mine and report another issue I forgot about.

project64 pushed a commit that referenced this issue Feb 21, 2015
is this how I get update to my fork from master?
project64 pushed a commit that referenced this issue Mar 1, 2015
project64 pushed a commit that referenced this issue Mar 4, 2015
project64 added a commit that referenced this issue May 5, 2015
Revert DoSomething from bool to BOOL #2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants