Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added option to remove cursor from sdl window #75

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

JannisKirschner
Copy link

Hey folks,
Ever opened the frontend but couldn't figure out where to best place the os cursor so it's not as visible?
I created a commandline option to remove it if preferred for an unobstructed experience.

@kblaschke
Copy link
Member

kblaschke commented Apr 7, 2024

Actually a good idea, as the cursor is always visible in windowed mode as of now. I'd recommend waiting a bit for my Dear Imgui branch to be merged to master, which I'm going to do soon. There were lots of changes, and the mouse pointer must be visible while the UI is open. Currently, the mouse pointer is hidden when the UI is closed, no matter if the app is in fullscreen mode or not, but when toggling between windows/fullscreen mode, the pointer will be shown again in windowed mode, which isn't optimal.

I guess your suggested command-line option (plus adding a configuration/UI option) to permanently hide the mouse pointer in windowed mode is definitely the way to go!

That said, if you're patient until the merge is done, you can just rebase (or redo) the changes in this PR and add the proper options to the configuration file and UI's settings window as well.

To familiarize yourself with the new UI before the merge, feel free to check out and build the branch linked above!

Edit: Actually just opened PR #76 to merge the branch!

@kblaschke kblaschke added the enhancement New feature or request label Apr 7, 2024
@kblaschke kblaschke self-assigned this Apr 7, 2024
@kblaschke kblaschke self-requested a review April 7, 2024 19:18
@kblaschke
Copy link
Member

The initial UI code has just been merged - please rebase and see what you can improve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants