Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix the %l format given to print API only print 32bit #1230

Closed
fyin1-zz opened this issue Sep 13, 2018 · 2 comments
Closed

fix the %l format given to print API only print 32bit #1230

fyin1-zz opened this issue Sep 13, 2018 · 2 comments
Assignees
@fyin1-zz
Labels
priority: medium status: closed The issue been closed type: feature New feature
Projects
Roadmap
Milestone
v0.3

Comments

@fyin1-zz
Copy link

ACRN is running in 64bit. Suppose %l could print 64bit value. But it only print 32bit value in current implementation
@mwang106
Copy link
Contributor

mwang106 commented Sep 14, 2018 •
edited by Mingyuan18
Loading

[External_System_ID] ACRN-2144

@mwang106 mwang106 added type: feature New feature status: open The issue is working in progress priority: medium labels Sep 14, 2018
fyin1-zz pushed a commit to fyin1-zz/acrn-hypervisor that referenced this issue Sep 14, 2018
@fyin1
hv: long and long long is same for printf within x86_64
81dc8db 
In ACRN hypervisor, u/int64_t is defined as unsigned/ long.
It's nature to use %l to print it. But current printf use
%l to print int and only use %ll for long.

This patch fix it by treat long and long long same for printf.

Tracked-On: projectacrn#1230
Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
@fyin1-zz fyin1-zz mentioned this issue Sep 14, 2018
Merged
lijinxia pushed a commit that referenced this issue Sep 17, 2018
@fyin1 @lijinxia
hv: long and long long is same for printf within x86_64
c307e1b 
In ACRN hypervisor, u/int64_t is defined as unsigned/ long.
It's nature to use %l to print it. But current printf use
%l to print int and only use %ll for long.

This patch fix it by treat long and long long same for printf.

Tracked-On: #1230
Signed-off-by: Yin Fengwei <fengwei.yin@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
@mwang106 mwang106 added status: new The issue status: new for creation and removed status: open The issue is working in progress labels Sep 17, 2018
@hwang37 hwang37 added this to v0.8 in Roadmap Oct 10, 2018
@fyin1-zz
Copy link
Author

The patch was merged and mark the issue closed

@mwang106 mwang106 added status: closed The issue been closed and removed status: new The issue status: new for creation labels Nov 9, 2018
@hwang37 hwang37 moved this from v0.5 to v0.3 in Roadmap Nov 16, 2018
@hwang37 hwang37 added this to the v0.3 milestone Nov 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fyin1-zz fyin1-zz

Labels
priority: medium status: closed The issue been closed type: feature New feature
Projects
Roadmap
  
v0.3
Milestone
v0.3
Development

No branches or pull requests
3 participants
@fyin1-zz @mwang106 @hwang37