Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cbm length calculation,Extended model judge, print info error #3675

Closed
cdliuqiang opened this issue Sep 12, 2019 · 1 comment
Closed

cbm length calculation,Extended model judge, print info error #3675

cdliuqiang opened this issue Sep 12, 2019 · 1 comment
Assignees
@fuzhongl
Labels
priority: P3-Medium type: bug Something isn't working

Comments

@cdliuqiang
Copy link

  1. CPUID(EAX = 10H, ECX = ResID=1 or 2).EAX Bits 04 - 00: Length of the capacity bit mask for the corresponding ResID using minus-one notation
  2. The Extended Model ID needs to be examined only when the Family ID is 06H or 0FH
  3. check_name function, print info error
@cdliuqiang cdliuqiang mentioned this issue Sep 12, 2019
Closed
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 12, 2019
EAX Bits 04 - 00: Length of the capacity bit mask for the correspondi…
b06f0d8 
…ng ResID using minus-one notation

Tracked-On:projectacrn#3675
Signed-off-by: Andy andyx.liu@intel.com
@Mingyuan18
Copy link

[External_System_ID] ACRN-5175

@Mingyuan18 Mingyuan18 added priority: P3-Medium type: bug Something isn't working labels Sep 16, 2019
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 17, 2019
Fix the last problem: check_name function, print info error
effb21c 
Tracked-On:projectacrn#3675
Signed-off-by: Andy andyx.liu@intel.com
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 17, 2019
Fix the first problem: CPUID(EAX = 10H, ECX = ResID=1 or 2).EAX Bits …
9761efd 
…04 - 00: Length of the capacity bit mask for the corresponding ResID using minus-one notation

Tracked-On:projectacrn#3675
Signed-off-by: Andy <andyx.liu@intel.com>
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 17, 2019
Fix the second problem: The Extended Model ID needs to be examined on…
f1bd8a8 
…ly when the Family ID is 06H or 0FH

Tracked-On:projectacrn#3675
Signed-off-by: Andy <andyx.liu@intel.com>
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 17, 2019
Fix the last problem: check_name function, print info error
c2f8530 
Tracked-On:projectacrn#3675
Signed-off-by: Andy andyx.liu@intel.com
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 18, 2019
Fix the first problem: CPUID(EAX = 10H, ECX = ResID=1 or 2).EAX Bits …
b527609 
…04 - 00: Length of the capacity bit mask for the corresponding ResID using minus-one notation

Tracked-On:projectacrn#3675
Signed-off-by: Andy <andyx.liu@intel.com>
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 18, 2019
Fix the second problem: The Extended Model ID needs to be examined on…
1809c81 
…ly when the Family ID is 06H or 0FH

Tracked-On:projectacrn#3675
Signed-off-by: Andy <andyx.liu@intel.com>
cdliuqiang pushed a commit to cdliuqiang/acrn-hypervisor that referenced this issue Sep 18, 2019
Fix the last problem: check_name function, print info error
efc9337 
Tracked-On:projectacrn#3675
Signed-off-by: Andy andyx.liu@intel.com
@cdliuqiang cdliuqiang mentioned this issue Sep 18, 2019
Merged
wenlingz pushed a commit that referenced this issue Sep 19, 2019
@wenlingz
Fix the first problem: CPUID(EAX = 10H, ECX = ResID=1 or 2).EAX Bits …
857cdb0 
…04 - 00: Length of the capacity bit mask for the corresponding ResID using minus-one notation

Tracked-On:#3675
Signed-off-by: Andy <andyx.liu@intel.com>
wenlingz pushed a commit that referenced this issue Sep 19, 2019
@wenlingz
Fix the second problem: The Extended Model ID needs to be examined on…
04d5638 
…ly when the Family ID is 06H or 0FH

Tracked-On:#3675
Signed-off-by: Andy <andyx.liu@intel.com>
wenlingz pushed a commit that referenced this issue Sep 19, 2019
@wenlingz
Fix the last problem: check_name function, print info error
ad9e61b 
Tracked-On:#3675
Signed-off-by: Andy andyx.liu@intel.com
junjiemao1 pushed a commit to junjiemao1/acrn-hypervisor that referenced this issue Sep 28, 2019
@junjiemao1
Fix the second problem: The Extended Model ID needs to be examined on…
988c8ae 
…ly when the Family ID is 06H or 0FH

Tracked-On:projectacrn#3675
Signed-off-by: Andy <andyx.liu@intel.com>
wenlingz pushed a commit that referenced this issue Aug 14, 2020
@wenlingz
hv:cpu-caps:refine processor family and model info
538e7cf 
v3 -> v4:
Refine commit message and code stype

1.
SDM Vol. 2A 3-211 states DisplayFamily = Extended_Family_ID + Family_ID
when Family_ID == 0FH.
So it should be family += ((eax >> 20U) & 0xffU) when Family_ID == 0FH.

2.
IF (Family_ID = 06H or Family_ID = 0FH)
	THEN DisplayModel = (Extended_Model_ID « 4) + Model_ID;
While previous code this logic:
IF (DisplayFamily = 06H or DisplayFamily = 0FH)

Fix the bug about calculation of display family and
display model according to SDM definition.

3. use variable name to distinguish Family ID/Display Family/Model ID/Display Model,
then the code is more clear to avoid some mistake

Tracked-On:#3675

Signed-off-by: liujunming <junming.liu@intel.com>
Reviewed-by: Wu Xiangyang <xiangyang.wu@linux.intel.com>
Acked-by： Eddie Dong <eddie.dong@intel.com>
wenlingz pushed a commit that referenced this issue Aug 14, 2020
@wenlingz
hv:cpu-caps:refine is_apl_platform func and clean up duplicated code
3631a85 
Fix the bug for "is_apl_platform" func.
"monitor_cap_buggy" is identical to "is_apl_platform", so remove it.

On apl platform:
1) ACRN doesn't use monitor/mwait instructions
2) ACRN disable GPU IOMMU

Tracked-On:#3675

Signed-off-by: Junming Liu <junming.liu@intel.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fuzhongl fuzhongl

Labels
priority: P3-Medium type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@cdliuqiang @fuzhongl @Mingyuan18