Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hv:fix possible buffer overflow in 'ptirq_get_intr_data()' #2093

Merged
merged 1 commit into from Dec 18, 2018

Conversation

yonghuah
Copy link
Contributor

  • 'buffer'with size of 'buffer_cnt', will overflow in
    next loop if 'index == buffer_cnt - 1'.

Tracked-On: #1252
Signed-off-by: Yonghua Huang yonghua.huang@intel.com
Acked-by: Eddie Dong eddie.dong@intel.com

@ghost
Copy link

ghost commented Dec 18, 2018

2093
1 new potential violations to the coding guideline detected. Please help check. Thanks!

1.filename:/hypervisor/common/ptdev.c  function:ptirq_get_intr_data  offset:232:
       reason:Expression needs brackets.

@yonghuah
Copy link
Contributor Author

@HuiHuangShi thanks, have updated.

@ghost
Copy link

ghost commented Dec 18, 2018

2093
No new violations to the coding guideline detected.

@shiqingg shiqingg added the Coding Guidelines: PASS Coding Guidelines Manual Check label Dec 18, 2018
@wenlingz wenlingz merged commit b8ffac8 into projectacrn:master Dec 18, 2018
 - 'buffer'with size of 'buffer_cnt',  will overflow in
    next loop if 'index == buffer_cnt - 1'.

Tracked-On: projectacrn#1252
Signed-off-by: Yonghua Huang <yonghua.huang@intel.com>
Acked-by: Eddie Dong <eddie.dong@intel.com>
@yonghuah yonghuah deleted the hv_fix_buffer_overflow branch June 20, 2019 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Coding Guidelines: PASS Coding Guidelines Manual Check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants