This repository has been archived by the owner on Jul 29, 2018. It is now read-only.
Address #140 OpenShift service script on VM #191
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@praveenkumar Looks good to me. However it looks like we cant merge the PR at this stage as it wont be included in the ADB ks file at this form automatically. Once we decide how we want to include it in ADB, then we need to modify the patch and then merge it. |
|
Make sense, we will keep as it is till we have a plan around it. |
- Fix typo for variable - Remove duplicate code
|
Closing this as this is handled by https://github.com/projectatomic/adb-utils |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is address to use openshift as a service. Currently required origin/ose images should be available on target. To test it it contain
run.shwhich will place file in place and make sure you changesopenshift_optionaccording to your setup.