This repository has been archived by the owner on Feb 7, 2023. It is now read-only.
k8-cluster: revert to using older system containers #354
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Two major changes here: 1) Pin the system containers to a previous version that was working 2) Make sure that 'atomic 1.22' is installed on the host The new requirement on 'atomic 1.22' is to resolve the following issue with SELinux labeling - projectatomic/atomic#1185 This is only a temporary change; once the latest versions of the system containers are known to be working, we can revert a lot of this.
mike-nguyen
reviewed
Mar 12, 2018
| - ansible_distribution == 'Fedora' | ||
| - ansible_distribution_major_version | version_compare('26', '>') | ||
| - g_atomic_host is defined | ||
| - g_atomic_host['atomic'] | version_compare('1.22', '<=') |
There was a problem hiding this comment.
Does CAHC has atomic >= 1.22 so it doesn't need this step here?
There was a problem hiding this comment.
The logical AND should limit this to just Fedora hosts that are after F26 with a version of atomic less than 1.22
|
LGTM. Nice 🕵️♂️ work on tracking down the root cause. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two major changes here:
Pin the system containers to a previous version that was working
Make sure that 'atomic 1.22' is installed on the host
The new requirement on 'atomic 1.22' is to resolve the following issue
with SELinux labeling - projectatomic/atomic#1185
This is only a temporary change; once the latest versions of the
system containers are known to be working, we can revert a lot of
this.