Skip to content
This repository has been archived by the owner on Oct 10, 2020. It is now read-only.

help: prefer file over label #939

Closed
TomasTomecek opened this issue Mar 15, 2017 · 3 comments
Closed

help: prefer file over label #939

TomasTomecek opened this issue Mar 15, 2017 · 3 comments

Comments

@TomasTomecek
Copy link
Contributor

TomasTomecek commented Mar 15, 2017 •
edited

On our recent Fedora activity day, we decided that we would prefer atomic command to pick file in a container over label. Right now it's the other way around, label is preferred over file.

Would you be interested in such changes? If so, I will send a PR.

https://pagure.io/atomic-wg/issue/256
@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2017

I am fine with this, @baude WDYT?

The only problem I would see with this would be if someone wanted to add a layer onto a the container they would need to replace the file, if they wanted to change the help.

@TomasTomecek
Copy link
Contributor Author

The only problem I would see with this would be if someone wanted to add a layer onto a the container they would need to replace the file, if they wanted to change the help.

Or they can remove it. Yes it will leak in layers, but won't be present in container.

I think all metadata suffer from that issue: if you don't update them, you get them from base image. E.g. for labels this may get really confusing.

@rhatdan
Copy link
Member

rhatdan commented Mar 15, 2017

Submit a pull request.

TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue Mar 17, 2017
@TomasTomecek
change behavior of help command
84c6707 
Fixes projectatomic#939

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README, README.md

* references:
 * https://pagure.io/atomic-wg/issue/256
 * http://www.projectatomic.io/blog/2017/03/fedora-vfad-container-policy/

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek TomasTomecek mentioned this issue Mar 17, 2017
Closed
3 tasks
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue Mar 17, 2017
@TomasTomecek
change behavior of help command
3f45d2a 
Fixes projectatomic#939

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README, README.md

* references:
 * https://pagure.io/atomic-wg/issue/256
 * http://www.projectatomic.io/blog/2017/03/fedora-vfad-container-policy/

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue Apr 20, 2017
@TomasTomecek
Fixes projectatomic#939
02fd28a 
* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

* references:
 * https://pagure.io/atomic-wg/issue/256

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
@TomasTomecek TomasTomecek mentioned this issue Apr 27, 2017
Closed
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
762e04f 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
cc99a15 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
7233bff 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
2fcc40b 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
1541312 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
903ae44 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
59c8e94 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 4, 2017
@TomasTomecek
help: prefer help file over label
fead7df 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 5, 2017
@TomasTomecek
help: prefer help file over label
3f252bd 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 5, 2017
@TomasTomecek
help: prefer help file over label
970890e 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 5, 2017
@TomasTomecek
help: prefer help file over label
dc195e4 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 5, 2017
@TomasTomecek
help: prefer help file over label
8c583cf 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 9, 2017
@TomasTomecek
help: prefer help file over label
388038d 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 9, 2017
@TomasTomecek
help: prefer help file over label
4038760 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
TomasTomecek added a commit to TomasTomecek/atomic that referenced this issue May 9, 2017
@TomasTomecek
help: prefer help file over label
ff74bc9 
Fixes projectatomic#939

Reference: https://pagure.io/atomic-wg/issue/256#comment-436537

* The command now prefers files over "help" label.
 * Help files can be one of:
  * help.1, README.md

Signed-off-by: Tomas Tomecek <ttomecek@redhat.com>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@TomasTomecek @rhatdan