This repository has been archived by the owner on Oct 10, 2020. It is now read-only.
atomic-run: Add --volume option #40
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, this is a horrendous hack. We need something like a `RUNOPTS` metadata as a JSON array or something that can be clearly appended to instead of having shell script. Second and more importantly, it doesn't actually work because if the container is stopped we have no way to change its mount points currently. We'd have to detect the case where additional mounts were passed in on the command line - and AFAIK Docker doesn't support dynamically changing the mounts right now, though it would be possible at the kernel level.
|
I think the --opt1, --opt2, --opt3 should take care of this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, this is a horrendous hack. We need something like a
RUNOPTSmetadata as a JSON array or something that can be clearly appended to
instead of having shell script.
Second and more importantly, it doesn't actually work because if the
container is stopped we have no way to change its mount points
currently. We'd have to detect the case where additional mounts were
passed in on the command line - and AFAIK Docker doesn't support
dynamically changing the mounts right now, though it would be possible
at the kernel level.