Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

Fix namespaces in answers.conf #478

Open
rtnpro opened this issue Dec 31, 2015 · 1 comment
Open

Fix namespaces in answers.conf #478

rtnpro opened this issue Dec 31, 2015 · 1 comment
Assignees
Milestone

Comments

@rtnpro
Copy link
Contributor

rtnpro commented Dec 31, 2015

Problem

Given the current structure of answers.conf, there's high chance of namespace(where namespaces are nothing but app names) collisions in nested Nulecule apps. For example, if there's a nested Nulecule application as below:

Baseapp
|- components:
   |- app1
   |- app2
   |- app3 (external nulecule)
       |- components:
          |- app4
          |- app2

The params loaded for app2 in the different Nulecule applications will conflict each other in the section app2 of answers.conf. This is because the current namespace does not have any notion of hierarchy.

Solution

This can be easily solved in we update the way how we generate section names in answers.conf file to be more explicit as to which component in the Nulecule tree it is for:

[general]
foo=bar

[app1]
key1=var1

[app2]
key1=var2

[app3] # equivalent to general section for app3
key1=blah

[app3:app2] # component app2 for app3
key2=var3

[app3:app4]
some-key=some-val
@rtnpro
Copy link
Contributor Author

rtnpro commented Feb 8, 2016

@dustymabe @cdrage

Do we want to merge it for GA? If not, we should remove the GA milestone label from this issue.

@rtnpro rtnpro modified the milestones: CDK 2.1, CDK 2 GA Feb 9, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

1 participant