This repository has been archived by the owner on Jan 19, 2018. It is now read-only.
Cdk2 beta3 rc1 docs #341
Merged
Cdk2 beta3 rc1 docs #341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
| answers (dict or str): Answers data or local path to answers file | ||
| nodeps (bool): Install the nulecule application without installing | ||
| external dependencies | ||
| update (bool): Pull requistite Nulecule image and install or |
|
See above changes ^^, otherwise LGTM and good work!!! ✨ ✨ ✨ |
|
@dustymabe @charliedrage Made fixes in docs based on the above review. |
|
LGTM. @charliedrage ? |
rtnpro
force-pushed
the
cdk2-beta3-rc1-docs
branch
from
fdb9b82
to
2db7b11
Compare
|
@dustymabe rebased! Good to merge 👍 |
1 similar comment
|
LGTM 👍 merging |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added/fixed docs for new
atomicapp/nuleculecodebase.