Skip to content
This repository has been archived by the owner on Jan 19, 2018. It is now read-only.

cli: allow specifying target dir during atomic run #519

Merged
merged 1 commit into from
Jan 19, 2016

Conversation

dustymabe
Copy link
Contributor

This commit has one simple goal which is to allow atomic run to
be executed against an installed directory just a little easier.

Before this commit we need:

atomic install myapp --destination=/path/to/local/dir
atomic run myapp --destination=/path/to/local/dir

After this commit:

atomic install myapp --destination=/path/to/local/dir
atomic run myapp /path/to/local/dir

@rtnpro
Copy link
Contributor

rtnpro commented Jan 19, 2016

More intuitive. LGTM 👍

@kadel
Copy link
Collaborator

kadel commented Jan 19, 2016

why don't we allow same thing for install? eg. atomic install myapp /path/to/local/dir

@dustymabe
Copy link
Contributor Author

/path/to/local/dir is a path to an "existing" application that has been extracted. In the case of install there is not yet an "existing" application, otherwise you wouldn't be calling install.

Does that make sense?

@cdrage
Copy link
Member

cdrage commented Jan 19, 2016

LGTM 👍 and all tests pass!

This commit has one simple goal which is to allow `atomic run` to
be executed against an installed directory just a little easier.

Before this commit we need:

    atomic install myapp --destination=/path/to/local/dir
    atomic run myapp --destination=/path/to/local/dir

After this commit:

    atomic install myapp --destination=/path/to/local/dir
    atomic run myapp /path/to/local/dir
dustymabe added a commit that referenced this pull request Jan 19, 2016
cli: allow specifying target dir during atomic run
@dustymabe dustymabe merged commit 7fc2b51 into projectatomic:master Jan 19, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants