-
Notifications
You must be signed in to change notification settings - Fork 71
Conversation
Here's what it looks like right now if you pull the PR and run ▶ atomicapp index list
INFO :: Atomic App: 0.6.0 - Mode: Index
ID VER PROVIDERS LOCATION
postgresql-atomicapp 1.0.0 {D,O,K} docker.io/projectatomic/postgresql-centos7-atomicapp
flask_redis_nulecule 0.0.1 {D,K} docker.io/projectatomic/flask-redis-centos7-atomicapp
redis-atomicapp 0.0.1 {D,O,K} docker.io/projectatomic/redis-centos7-atomicapp
gocounter 0.0.1 {D,K} docker.io/projectatomic/gocounter-scratch-atomicapp
mariadb-atomicapp 1.0.0 {D,O,K} docker.io/projectatomic/mariadb-centos7-atomicapp
helloapache-app 0.0.1 {D,K,M} docker.io/projectatomic/helloapache
mongodb-atomicapp 1.0.0 {D,O,K} docker.io/projectatomic/mongodb-centos7-atomicapp
etherpad-app 0.0.1 {D,O,K} docker.io/projectatomic/etherpad-centos7-atomicapp
apache-centos7-atomicapp 0.0.1 {D,K,M} docker.io/projectatomic/apache-centos7-atomicapp
wordpress-atomicapp 2.0.0 {D,O,K} docker.io/projectatomic/wordpress-centos7-atomicapp
skydns-atomicapp 0.0.1 {K} docker.io/projectatomic/skydns-atomicapp
guestbookgo-atomicapp 0.0.1 {O,K} docker.io/projectatomic/guestbookgo-atomicapp
mariadb-app 0.0.1 {D,K} docker.io/projectatomic/mariadb-fedora-atomicapp
gitlab-atomicapp 1.2.0 {D,K} docker.io/projectatomic/gitlab-centos7-atomicapp Updating: dropbox/dev/atomicapp add-index ✔ 0m ⍉
▶ atomicapp index list --update
INFO :: Atomic App: 0.6.0 - Mode: Index
INFO :: Updating the index list
INFO :: Pulling latest index image...
INFO :: Skipping pulling docker image: cdrage/nulecule-library
INFO :: Extracting Nulecule data from image cdrage/nulecule-library to /home/wikus/.atomicapp/index.yaml
INFO :: Index updated |
e984e61
to
38393aa
Compare
projectatomic/nulecule-library#96 location metadata has been added for updating the information (including docker.io urls) |
e506577
to
b18a177
Compare
Hey guys. Pretty much done at this point in terms of Atomic App code. Here are the updates
In order to try out this PR, you must:
Hope you guys like it :) |
What I'm waiting for/block with is:
|
4556605
to
9b3ea0c
Compare
# eliminating the INFO :: Atomic App: X.X.X - Mode: Index | ||
# logging information. If we passed --debug, ignore. | ||
# if not logging.getLogger().getEffectiveLevel() == logging.DEBUG: | ||
# sys.stdout.write("\033[F") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove?
https://hub.docker.com/r/projectatomic/nulecule-library/ has been created with the index.yaml This has been update and ready for code review + possible merging. @dustymabe @rtnpro @containscafeine @kadel if ya'll want to try it out / review it :) |
I'll be updating the docs in a separate PR since we need to update https://github.com/projectatomic/atomicapp/blob/master/docs/cli.md anyways. |
#dotests |
|
||
index_list = index_action.add_parser("list") | ||
index_list.add_argument( | ||
"--update", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
so what do you think about having this as a separate subcommand rather than an option to --list
? seems like atomicapp index update
would be more natural than atomicapp index list --update
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about atomicapp index pull
? (It's a docker pull anyway:) )
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That'd be good, what do you think @dustymabe ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ehh i like "update" but don't really care.. potato potato - go with whatever
updated based on your comments. added the |
#dotests |
index_generate.add_argument( | ||
"location", | ||
help=( | ||
"Path or Git repository link containing Nulecule applications " |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'or Git repository' - is that still true?
Hey @dustymabe So the index_location has been updated in the
has also been added to the One last review? :) |
And the permissions:
|
This adds an index command to list multiple Nulecule's from an external library that contains an index.yaml file in it's root directory.
LGTM |
#dotests |
This adds an index command to list multiple Nulecule's from an external
library that contains an index.yaml file in it's root directory.
Built upon @vpavlin 's work :)
TODO:
atomicapp index list --update
command