Skip to content
This repository has been archived by the owner on Mar 22, 2018. It is now read-only.

Create Common Reusable CLI Parser For Services #21

Closed
ashcrow opened this issue Oct 18, 2016 · 2 comments
Closed

Create Common Reusable CLI Parser For Services #21

ashcrow opened this issue Oct 18, 2016 · 2 comments
Labels
enhancement help wanted

Comments

@ashcrow
Copy link
Collaborator

ashcrow commented Oct 18, 2016

Services should all take in the, at a minimum, the following as CLI arguments:

  • config
  • bus-exchange
  • bus-uri

Having a common parser which can be extended and used in services will help us keep DRY.

Example: https://github.com/projectatomic/commissaire-service/blob/master/src/commissaire_service/storage/__init__.py#L207-L237
@ashcrow ashcrow mentioned this issue Oct 18, 2016
Closed
@mbarnes
Copy link
Contributor

mbarnes commented Oct 18, 2016

Yes, it's good to be dry. Being not dry is gross.

@intlabs intlabs mentioned this issue Oct 19, 2016
Closed
@ashcrow ashcrow mentioned this issue Dec 16, 2016
Merged
@mbarnes mbarnes mentioned this issue Jan 9, 2017
Closed
@mbarnes
Copy link
Contributor

mbarnes commented Feb 7, 2017

Closing. This was addressed in the above referenced PRs.

@mbarnes mbarnes closed this as completed Feb 7, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ashcrow @mbarnes