Skip to content
This repository has been archived by the owner on Mar 22, 2018. It is now read-only.

Give all services a configuration file #40

Merged
merged 2 commits into from Dec 16, 2016
Merged

Give all services a configuration file #40

merged 2 commits into from Dec 16, 2016

Conversation

mbarnes
Copy link
Contributor

@mbarnes mbarnes commented Dec 15, 2016

All services can have their own logging configuration, if nothing else.

Requires: projectatomic/commissaire#77

Make the "debug" setting explicit in all configuration files so it's
easier to enable debug messages.
Even if there's no service-specific configuration settings defined,
the file may still contain logging configuration.
@mbarnes mbarnes added the WIP label Dec 15, 2016
@mbarnes mbarnes changed the title [WIP] Give all services a configuration file Give all services a configuration file Dec 16, 2016
@mbarnes mbarnes added enhancement and removed WIP labels Dec 16, 2016
@mbarnes mbarnes requested a review from ashcrow December 16, 2016 16:04
@ashcrow ashcrow self-assigned this Dec 16, 2016
Copy link
Collaborator

@ashcrow ashcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -138,6 +145,9 @@ def main(): # pragma: no cover

parser = argparse.ArgumentParser()
parser.add_argument(
'-c', '--config', type=str,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Example for #21

@ashcrow ashcrow merged commit c207529 into projectatomic:master Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants