Skip to content
This repository has been archived by the owner on Mar 22, 2018. It is now read-only.

Remove/update default bus-uri from services #28

Closed
ashcrow opened this issue Nov 15, 2016 · 2 comments
Closed

Remove/update default bus-uri from services #28

ashcrow opened this issue Nov 15, 2016 · 2 comments
Assignees
Labels

Comments

@ashcrow
Copy link
Collaborator

ashcrow commented Nov 15, 2016

A default bus-uri was set pre-release for testing. It should be removed or updated to better default.

Example: https://github.com/mbarnes/commissaire-service/blob/8123d85562a7d72bdf204fd3f8330b83e3219b43/src/commissaire_service/clusterexec/__init__.py#L287

@mbarnes
Copy link
Contributor

mbarnes commented Nov 16, 2016

What constitutes a "better" default? Is it the redis part that's objectionable?

@ashcrow
Copy link
Collaborator Author

ashcrow commented Nov 16, 2016

@mbarnes a better default could be redis if we decide that redis is the default expected "bus". Right now we don't define one we expect as a default and we have been using redis for testing.

ashcrow added a commit to ashcrow/commissaire-service that referenced this issue Mar 8, 2017
@mbarnes mbarnes closed this as completed in 4d5c876 Mar 8, 2017
@ashcrow ashcrow self-assigned this Mar 8, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants