Adjust Audit init in 1.12.6 to match 1.13.1 #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: TomSweeneyRedHat tsweeney@redhat.com
- What I did
While working on #293 I noted that the dockerd/daemon.go code in 1-13.1-rhel initialized the audit logging code in a similar manner to my fix in #292. This change brings the code in 1-12.6 in line with 1-13.1 which primarily adds a warning in a comment about the order of initialization for audit log.
- How I did it
vi is my friend, and lots of testing.
- How to verify it
There should be no discernible run time changes, the code works the same, it's just a little better ordered and commented in the code for future code maintenance.
- Description for the changelog
Adjust internal ordering of audit logging.
This is part of the series of fixes for https://bugzilla.redhat.com/show_bug.cgi?id=1496176