Skip to content
This repository has been archived by the owner on Mar 22, 2018. It is now read-only.

Automatically enable single language mode (#1235726) #3

Merged
merged 1 commit into from May 12, 2016

Conversation

M4rtinK
Copy link
Contributor

@M4rtinK M4rtinK commented May 12, 2016

Automatically enable the single language mode for Atomic installations.

Atomic installations are always single language (and en_US.UTF-8) so
the ability to interactively change language settings during the
installation can be actually harmful (see bug 1235726 for more
details).

The single language mode takes care of this by disabling interactive
language configuration during the installation.

Automatically enable the single language mode for Atomic installations.

Atomic installations are always single language (and en_US.UTF-8) so
the ability to interactively change language settings during the
installation can be actually harmful (see bug 1235726 for more
details).

The single language mode takes care of this by disabling interactive
language configuration during the installation.
@cgwalters
Copy link
Member

Seems sane, although I should note this is actually a property of the content and not specifically rpmostreepayload. Atomic Host uses it now, but AFAIK the plans for Fedora Workstation are to enable documentation.

So long term, it would be more flexible if we figured out a mechanism for looking at the content payload.

@cgwalters
Copy link
Member

Do you know offhand if this is available in F23 Anaconda? I'm just wondering what backporting hazards there might be.

@cgwalters cgwalters merged commit 20cd66d into projectatomic:master May 12, 2016
@M4rtinK
Copy link
Contributor Author

M4rtinK commented May 12, 2016

Do you know offhand if this is available in F23 Anaconda? I'm just wondering what backporting hazards there might be.

The single-language code is quite new, so it is not in F23. Availability should be like this:

  • Fedora: 25.12 (so Rawhide for now)
  • RHEL 7: 21.48.22.71 (already enables single language mode for Atomic installs as the install class is part of Anaconda on RHEL 7)

Seems sane, although I should note this is actually a property of the content and not specifically >rpmostreepayload. Atomic Host uses it now, but AFAIK the plans for Fedora Workstation are to enable >documentation.

So long term, it would be more flexible if we figured out a mechanism for looking at the content payload.

Yeah - if it can be introspected from the content it should be easy to modify the code setting the singlelang flag accordingly. The only issue could be that you would need to know that before reaching the welcome spoke & summary hub as enabling single language spoke so late would make little sense.

@cgwalters
Copy link
Member

I followed up on the ML for this since it's better for architecture discussion: https://www.redhat.com/archives/anaconda-devel-list/2016-May/msg00001.html

@cgwalters
Copy link
Member

And thanks for the patch again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants